Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait until guest get IP in setup_dns #20261

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Wait until guest get IP in setup_dns #20261

merged 1 commit into from
Oct 10, 2024

Conversation

Julie-CAO
Copy link
Contributor

@Julie-CAO Julie-CAO commented Sep 25, 2024 •
edited
Loading

Related ticket: https://progress.opensuse.org/issues/167569

  • Wait until guests get an IP
  • Remove lsb_release command in test script, because
    • the lsb_release package was not installed by unknown reasons
    • it is useless to get the SLE version any more
  • Fix typo
  • Add a few debug lines
  • Run reset_partition.pm for prj1 tests only

Verification run:
sriov_pci_passthrough-guest_developing_fv-on-host_developing-xen
sriov_pci_passthrough-guest_sles15sp6_fv-on-host_developing-xen
gi-guest_developing-on-host_developing-kvm
gi-guest_win2022-on-host_developing-xen

@Julie-CAO Julie-CAO changed the title Debug prj3 [WIP]Debug prj3 Sep 25, 2024
@Julie-CAO Julie-CAO force-pushed the julie/debug branch 6 times, most recently from f7318e9 to d93db72 Compare September 30, 2024 06:56
@Julie-CAO Julie-CAO changed the title [WIP]Debug prj3 [WIP]Wait until guest get IP in setup_dns Sep 30, 2024
@Julie-CAO Julie-CAO changed the title [WIP]Wait until guest get IP in setup_dns Wait until guest get IP in setup_dns Sep 30, 2024
@Julie-CAO
Copy link
Contributor Author

@alice-suse @waynechen55 @guoxuguang and others, welcome review!

@guoxuguang
Copy link
Contributor

LGTM

@alice-suse
Copy link
Contributor

Thanks for the fix, Julie! I am not very familiar with this file logic, so will rely more on the file creator's review opinion. Anything fixing the issue is fine for me!
If I understand correctly, this is one of the main issues in current 15sp7 job groups, so let's treat this review with higher priority than other issues. @waynechen55 Thanks!

@alice-suse
Copy link
Contributor

Thanks for the fix, Julie! I am not very familiar with this file logic, so will rely more on the file creator's review opinion. Anything fixing the issue is fine for me! If I understand correctly, this is one of the main issues in current 15sp7 job groups, so let's treat this review with higher priority than other issues. @waynechen55 Thanks!

@waynechen55 Would you please give priority to review this PR? We'd better have this before tomorrow's last alpha milestone candidate comes.

waynechen55
waynechen55 reviewed Oct 9, 2024
View reviewed changes
data/virt_autotest/setup_dns_service.sh
get_vm_ipaddress=`tac $dhcpd_lease_file | awk '!($0 in S) {print; S[$0]}' | tac | grep -iE "${vm_macaddresses_array[${vm_hash_index}]}" -B8 | grep -oE "([0-9]{1,3}\.){3}[0-9]{1,3}" | tail -1`
[[ -n "$vm_ipaddress" ]] && break
sleep 10
done
Copy link
Contributor

@waynechen55 waynechen55 Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that if guest gets ip address from internal dns service, it will not take so long to get a ip address. According to my observation, such guest can be fully up and running within 60 seconds.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 tests always failed since sle15sp7:
https://10.145.10.207/tests/15612775#next_previous
https://10.145.10.207/tests/15612782#next_previous
They spent more time in getting an IP with unknown reasons.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long do they need ? Is it this specific to SRIOV scenario (SRIOV attached network interface) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How long do they need ?

I reproduced before the long holiday, it took nearly 3 minutes if I recalled correctly... I am not quite certain about the exact time since it has been too long since then.

Is it this specific to SRIOV scenario (SRIOV attached network interface) ?

No, this module is ahead of SRIOV tests. It runs after downloading and restoring a guest disk.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this issue happens frequently, is really significant and does not happen to other machines, I think you can do comparison with/out SRIOV settings ??? Or it only happens to certain machines regardless of SRIOV ???

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW @waynechen55 , how do you suggest to go for this PR now? Merge it and you debug separately to have sooner milestone result, or not merge it and wait for a potential new solution by you?

I think I gave my opinions clearly, but I do not mind doing it again.

I think it worth having a look because test run on a network SR-IOV enabled host. You can still have a deeper look with this pull request in place when there is resource.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup_dns has been always running on SR-IOV enabled host for a long time ... If you think there is a bug or problem on sle15sp7 in setup_dns, it will be good that you can open a bug. but for sriov passthrough tests to guest, I did not find a bug so far.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I think it worth having a look because test run on a network SR-IOV enabled host. You can still have a deeper look with this pull request in place when there is resource. I am happy if you confirm there is no issue at the moment or in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I will only take care of sriov test failure. About setup_dns problems, such as why the guest gets its IP longer than sle15sp6, it is beyond my knowledge and out of my fields.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. You can intervene test run manually and try boot vm manually on your SR-IOV enabled host to have a deeper look at this issue in the future.

waynechen55
waynechen55 reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@waynechen55 waynechen55 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this comment. Anyone can help delete this comment is better.

@alice-suse
Copy link
Contributor

With offline confirmation, let's merge it now to unblock test first, and then investigate further.

@alice-suse alice-suse merged commit 09fa14a into os-autoinst:master Oct 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynechen55 waynechen55 waynechen55 left review comments

@alice-suse alice-suse alice-suse left review comments

@cachen cachen cachen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Julie-CAO @guoxuguang @alice-suse @cachen @waynechen55